Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Google Places (new) #77

Open
flikkr opened this issue Mar 29, 2024 · 4 comments
Open

Add support for Google Places (new) #77

flikkr opened this issue Mar 29, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@flikkr
Copy link
Contributor

flikkr commented Mar 29, 2024

Hi @matanshukry

Thanks for the awesome package! Google Places has since updated their SDK and now call this new version Google Places (new). It adds a new text search API, a Review object, more place fields to filter by, and other changes, including an adjusted pricing model.

It would be great to support this new version in this plugin. I'm working on updating some of these packages to support this new version on Android side, but would need some support for iOS. I'm opening this ticket for posterity and tracking.

@Agyapaldhiman
Copy link

Any update on this?

@flikkr
Copy link
Contributor Author

flikkr commented Jun 28, 2024

I have an initial PR #87 pending which updates the interface for the new features. I would need @matanshukry to review before we get to the rest of the changes.

@Josian2004
Copy link

Hi, I would like to assist in getting the new APIs added and I could help with the iOS part as I do have some experience with Swift. However I've got no idea how far along the implementation for the new API is and where I should begin with the iOS implementation.
My experience with developing Flutter packages is basically non-existent but I hope that I can still help getting this added ASAP

@flikkr
Copy link
Contributor Author

flikkr commented Jan 14, 2025

Hi @Josian2004, happy to hear you are open to contribute. Since this is quite a technical integration with calls to native platform, I would suggest you first familiarise yourself with how Flutter packages and plugins work. There are plenty of resources on youtube but I would you get started by reading the official docs. Do note that this project is using a federated plugin structure, so each platform's implementation is contained in its own package (ios implementation is here).

Once you start developing the iOS code, please update the Places SDK to 9.0.0 for now to match the release on Android. You can see the release notes for iOS here to give you an idea of what needs to be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants