Expanding search results stops early

[ClearlyClaire]

Steps to reproduce the problem

1. Search for some term in the Mastodon Web interface
2. Load past the initial results
3. Continue scrolling/loading more

Expected behaviour

All results should be returned eventually

Actual behaviour

The interface stops offering to load more results before they have all been returned

Detailed description

This is caused by the hasMore logic in app/javascript/mastodon/features/search/index.tsx relying on the number of results being equal to 1 modulo 10.

This logic is really brittle, and in particular will always break after a few pages because we expand new results by 11 new items, not 10.

Mastodon instance

mastodon.social

Mastodon version

v4.4.0-nightly.2024-12-18

Browser name and version

Firefox 133

Operating system

Linux

Technical details

No response

[horaceyoung]

Is there any need to update the search index. I've merged this change for my instance but still having search results stopping early at the 10th post. My commit is up to glitch-soc@53f8ac0
The issue is frequently encountered with non-English languages with few results (but definitely more than 10)

[ClearlyClaire]

There is no need to rebuild search indexes, the issue discussed here (and partially addressed by #33428) is purely a front-end issue.

In your case, I would double-check that assets have been rebuilt and mastodon-web then restarted.