Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonSerializable fatal error is thrown on Massive\Bundle\SearchBundle\Search\QueryHit #182

Open
dfsoeten opened this issue Jan 23, 2025 · 2 comments

Comments

@dfsoeten
Copy link
Contributor

Similar to issue fixed by #178 , the following exception is thrown in my Sulu project:

<b>Fatal error</b>:  During inheritance of JsonSerializable: Uncaught ErrorException: Return type of Massive\Bundle\SearchBundle\Search\QueryHit::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /app/vendor/massive/search-bundle/Search/QueryHit.php:70

Should the #[\ReturnTypeWillChange] be added there as well?

Sulu version: 2.6.5
PHP: PHP 8.3.12
FrankenPHP: FrankenPHP v1.2.5 PHP 8.3.12 Caddy v2.8.4 h1:q3pe0wpBj1OcHFZ3n/1nl4V4bxBrYoSoab7rL9BMYNk=

@dfsoeten dfsoeten changed the title JsonSerializable deprecation is thrown on Massive\Bundle\SearchBundle\Search\QueryHit JsonSerializable fatal error is thrown on Massive\Bundle\SearchBundle\Search\QueryHit Jan 23, 2025
@alexander-schranz
Copy link
Member

Make sense please create a PR for it.

@dfsoeten
Copy link
Contributor Author

dfsoeten commented Jan 23, 2025

@alexander-schranz not sure if you were notified, but I have created a PR. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants