Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getWallets silently fails #281

Open
pivilartisant opened this issue Jan 2, 2025 · 1 comment · May be fixed by #282
Open

getWallets silently fails #281

pivilartisant opened this issue Jan 2, 2025 · 1 comment · May be fixed by #282
Assignees

Comments

@pivilartisant
Copy link
Collaborator

When a user has a broken metamask install, getWallets() silently fails.

The underlying most likely comes from this function where if metamask is installed but broken = user cannot open it silently fails

Since we can't debug on the metamask provider side, for now we should find an alternative to using promise.all() which prevents the initial getWallets() function from resolving thus creating a bug when fetching wallets from provider

@pivilartisant pivilartisant self-assigned this Jan 2, 2025
@pivilartisant pivilartisant linked a pull request Jan 3, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@pivilartisant and others