From 8eefe89a25a7e3f86dae2426ef6fe7290afa9a79 Mon Sep 17 00:00:00 2001 From: BenRey <44082144+Ben-Rey@users.noreply.github.com> Date: Thu, 10 Oct 2024 11:42:30 +0200 Subject: [PATCH] Add id attribute to dropdown button for improved accessibility (#487) * Add id attribute to dropdown button for improved accessibility * Update upload-artifact action to version 3 in CI workflow * Update package-lock.json to remove deprecated dependencies and update versions --- .github/workflows/tests.yml | 2 +- package-lock.json | 70 ++++------------------------ src/components/Dropdown/Dropdown.tsx | 1 + 3 files changed, 11 insertions(+), 62 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 6cf75176..45a1f1d4 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -26,7 +26,7 @@ jobs: VITE_CI_TEST: true - name: Upload Artifacts if: always() - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: test-results-${{ matrix.node-version }} path: | diff --git a/package-lock.json b/package-lock.json index c710b02f..ab62a595 100644 --- a/package-lock.json +++ b/package-lock.json @@ -3952,14 +3952,6 @@ "integrity": "sha512-dfLbk+PwWvFzSxwk3n5ySL0hfBog779o8h68wK/7/APo/7cgyWp5jcXockbxdk5kFRkbeXWm4Fbi9FrdN381sA==", "dev": true }, - "node_modules/@lukeed/csprng": { - "version": "1.1.0", - "resolved": "https://registry.npmjs.org/@lukeed/csprng/-/csprng-1.1.0.tgz", - "integrity": "sha512-Z7C/xXCiGWsg0KuKsHTKJxbWhpI3Vs5GwLfOean7MGyVFGqdRgBbAjOCh6u4bbjPc/8MJ2pZmK/0DLdCbivLDA==", - "engines": { - "node": ">=8" - } - }, "node_modules/@massalabs/eslint-config": { "version": "0.0.9", "resolved": "https://registry.npmjs.org/@massalabs/eslint-config/-/eslint-config-0.0.9.tgz", @@ -3977,15 +3969,14 @@ } }, "node_modules/@massalabs/massa-web3": { - "version": "5.0.0-next.20240826165639", - "resolved": "https://registry.npmjs.org/@massalabs/massa-web3/-/massa-web3-5.0.0-next.20240826165639.tgz", - "integrity": "sha512-w8n2wWX72HOybr6QETP3JQQHAHdcWyBHKcXuZWaT+wZMem54zmN3Ajd/fLHfCHB7v+Sw7xetnoonQK10l8HW3A==", + "version": "5.0.0-next.20241008103931", + "resolved": "https://registry.npmjs.org/@massalabs/massa-web3/-/massa-web3-5.0.0-next.20241008103931.tgz", + "integrity": "sha512-hCkyJr1GSrekV19tNoOqXeyZJWOj1560T+FvWRVxrZ7P4Ap6+sPfvdex6xRfMAsw8SWV593/Hcq7QfTJ35O9+g==", "dependencies": { "@noble/ed25519": "^1.7.3", "@noble/hashes": "^1.2.0", "@open-rpc/client-js": "^1.8.1", "@open-rpc/schema-utils-js": "1.15.0", - "big-varint": "^0.1.3", "bs58check": "^4.0.0", "decimal.js": "^10.4.3", "dotenv": "^16.0.3", @@ -4011,44 +4002,15 @@ } }, "node_modules/@massalabs/wallet-provider": { - "version": "3.0.0-next.20240826165834", - "resolved": "https://registry.npmjs.org/@massalabs/wallet-provider/-/wallet-provider-3.0.0-next.20240826165834.tgz", - "integrity": "sha512-w2xXV3rEESiFUadA77GJ+3qvgexTHTMi/4AGkWeWeKOKBQNDJkWH/Mto4E0f9dEa6SdTWEO2MOTXiTtrO+qCSg==", + "version": "3.0.0-next.20241004095002", + "resolved": "https://registry.npmjs.org/@massalabs/wallet-provider/-/wallet-provider-3.0.0-next.20241004095002.tgz", + "integrity": "sha512-z05YzRtejvyH3bcl8EJkjRZthm1nziF+uU2iSaDJkkNEt4u3vdZFnbqSkgtCwJ8Ocmwz8eGWC5BcVaLNqSCNzA==", "dependencies": { "@hicaru/bearby.js": "^0.5.8", "@massalabs/massa-web3": "^5.0.0-next", "axios": "^0.28.0", "bs58check": "^4.0.0", - "buffer": "^6.0.3", - "eventemitter3": "^5.0.1", - "uid": "^2.0.1" - }, - "optionalDependencies": { - "bufferutil": "^4.0.7", - "utf-8-validate": "^6.0.2" - } - }, - "node_modules/@massalabs/wallet-provider/node_modules/buffer": { - "version": "6.0.3", - "resolved": "https://registry.npmjs.org/buffer/-/buffer-6.0.3.tgz", - "integrity": "sha512-FTiCpNxtwiZZHEZbcbTIcZjERVICn9yq/pDFkTl95/AxzD1naBctN7YO68riM/gLSDY7sdrMby8hofADYuuqOA==", - "funding": [ - { - "type": "github", - "url": "https://github.com/sponsors/feross" - }, - { - "type": "patreon", - "url": "https://www.patreon.com/feross" - }, - { - "type": "consulting", - "url": "https://feross.org/support" - } - ], - "dependencies": { - "base64-js": "^1.3.1", - "ieee754": "^1.2.1" + "eventemitter3": "^5.0.1" } }, "node_modules/@mdx-js/react": { @@ -9622,6 +9584,7 @@ "version": "1.5.1", "resolved": "https://registry.npmjs.org/base64-js/-/base64-js-1.5.1.tgz", "integrity": "sha512-AKpaYlHn8t4SVbOHCy+b5+KKgvR4vrsD8vbvrbiQJps7fKDTkjkDry6ji0rUJjC0kzbNePLwzxq8iypo41qeWA==", + "dev": true, "funding": [ { "type": "github", @@ -9669,11 +9632,6 @@ "node": ">=0.6" } }, - "node_modules/big-varint": { - "version": "0.1.3", - "resolved": "https://registry.npmjs.org/big-varint/-/big-varint-0.1.3.tgz", - "integrity": "sha512-HgJQG8DtWAaYtrXTCasQukrMO0jbtQpd4BPEjr+JHoLRrbyIr8IxrMp01OZVJCoZBdqGynGHvp2iz0mabXz6dA==" - }, "node_modules/big.js": { "version": "5.2.2", "resolved": "https://registry.npmjs.org/big.js/-/big.js-5.2.2.tgz", @@ -13839,6 +13797,7 @@ "version": "1.2.1", "resolved": "https://registry.npmjs.org/ieee754/-/ieee754-1.2.1.tgz", "integrity": "sha512-dcyqhDvX1C46lXZcVqCpK+FtMRQVdIMN6/Df5js2zouUsqG7I6sFxitIC+7KYK29KdXOLHdu9zL4sFnoVQnqaA==", + "dev": true, "funding": [ { "type": "github", @@ -22117,17 +22076,6 @@ "node": ">=0.8.0" } }, - "node_modules/uid": { - "version": "2.0.2", - "resolved": "https://registry.npmjs.org/uid/-/uid-2.0.2.tgz", - "integrity": "sha512-u3xV3X7uzvi5b1MncmZo3i2Aw222Zk1keqLA1YkHldREkAhAqi65wuPfe7lHx8H/Wzy+8CE7S7uS3jekIM5s8g==", - "dependencies": { - "@lukeed/csprng": "^1.0.0" - }, - "engines": { - "node": ">=8" - } - }, "node_modules/undici": { "version": "5.28.4", "resolved": "https://registry.npmjs.org/undici/-/undici-5.28.4.tgz", diff --git a/src/components/Dropdown/Dropdown.tsx b/src/components/Dropdown/Dropdown.tsx index df387a0b..122fde9c 100644 --- a/src/components/Dropdown/Dropdown.tsx +++ b/src/components/Dropdown/Dropdown.tsx @@ -120,6 +120,7 @@ export function Dropdown(props: DropdownProps) { {...rest} >