Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal fees #1340

Closed
3 tasks
Thykof opened this issue Apr 8, 2024 · 2 comments
Closed
3 tasks

Minimal fees #1340

Thykof opened this issue Apr 8, 2024 · 2 comments
Assignees

Comments

@Thykof
Copy link
Contributor

Thykof commented Apr 8, 2024

Context
Describe / explain why we should do this: motivations, context or other info. Keep it brief and simple - PM

Massa network will have a new feature of minimal operation fees.

User flow
Describe the user flow using user stories so the end result is super clear - PM

User will see in massa station wallet the fees that will allow the operation to get accepted by the node and included in a block.

Concerns:

  1. the dapp may show to user that there no fee, but the sign prompt will show fees. Maybe we can add a tooltip saying that user is connected to a node that accept only operations with at leat 0.01 MAS fee?
  2. the fee field is editable in the sign prompt, should we allow user to set a value bellow the minimal fee of the node?

How to
List the step-by-step to get it do if needed - PM

  • Massa station, when connecting to a node, fetch the amount of minimal fees
  • Massa station, when receiving an execute function request, will modify the operation to put at least the minimal of the connected node
  • UX: cc @SlnPons @LucasF243 see the too concerns above ;)

Technical details
Give the technical insights so anyone in the team can tackle the tasks - Dev

the logic will be in sendoperation::Call

QA testing
Does this task require some QA tests ?
If yes, explain how to validate it

@Thykof Thykof self-assigned this Apr 8, 2024
@Thykof Thykof transferred this issue from massalabs/station-massa-wallet Apr 8, 2024
@Thykof Thykof linked a pull request Apr 8, 2024 that will close this issue
@SlnPons
Copy link
Contributor

SlnPons commented Apr 11, 2024

@Thykof do you think you can address this issue at the same time? massalabs/station-massa-wallet#814

@Thykof
Copy link
Contributor Author

Thykof commented Apr 18, 2024

no need to change station

@Thykof Thykof closed this as completed Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants