Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: edit allowance in wails #855

Open
2 tasks
pivilartisant opened this issue Dec 14, 2023 · 0 comments
Open
2 tasks

Feature Request: edit allowance in wails #855

pivilartisant opened this issue Dec 14, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@pivilartisant
Copy link
Contributor

pivilartisant commented Dec 14, 2023

Context
In the context of the bridge, we want users to be able to edit token allowance during redeem approval. This extends to other dApps that use allowance function for tokens.

User flow
As a user, I want to be able to manually edit allowance and give dApps approval to move specific amounts of tokens from my balance.

I want a button that directly sets max allowance possible.

If the allowance that I entered is inferior to the amount, I want to see a warning telling this to me, but i still want to be able to sign if this is the case. NOTE: this one might not make sense in all cases, the need should be further checked.

Ideally the allowance displayed in wails is not a bigInt (better UX).

How to

  • BE modifications (TBD)
  • FE Modifications (TBD)

Technical details
Case: increaseAllowance fn for operation type Call SC

If the user sets an allowance < amount, burn should throw an error that can be caught and displayed in FE.

@loonggamma loonggamma added the enhancement New feature or request label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants