Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign operation - Add operation cost, hide technical parameters, edit fees #786

Closed
2 of 3 tasks
loonggamma opened this issue Oct 16, 2023 · 1 comment
Closed
2 of 3 tasks
Assignees
Milestone

Comments

@loonggamma
Copy link
Contributor

loonggamma commented Oct 16, 2023

Context
Tackles the part of the Need 1 identified in the 'improvement of Sign operation' suggestions for SC-type operations, transaction and roll buy/sell initiated by a dapp. The need should also applied transactions sent in-app.

User flow
All types of Operations initiated by dApps:

  • initiate operations types
  • Sign wails pop up is shown to the user.
  • Display only the Operation cost, which is a sum of 'fees' + 'coins' parameters.
  • User must be able to edit parameter 'fees'.

Sending Transactions in MW:

  • initiate MAS transfer in the wallet
  • Sign wails pop up is shown to the user
  • instead of transaction fee show 'Operation cost' as mentioned above.
  • User must be able to edit parameter 'fees'.

How to

Designs for Wails pop up: https://www.figma.com/file/LSaOibVDFb1reF6FePVn5l/Massastation?type=design&node-id=6671-41583&mode=design&t=eRL7yXNkjLB0lf71-0

Edit fees flow: https://www.figma.com/file/LSaOibVDFb1reF6FePVn5l/Massastation?type=design&node-id=6845-13599&mode=design&t=YrmdmD91CV1EVFlo-0

Technical details
Give the technical insights so anyone in the team can tackle the tasks - Dev

QA testing
Does this task require some QA tests ?
If yes, explain how to validate it

@loonggamma loonggamma changed the title Sign operation - Add operation cost, hide technical parameters Sign operation - Add operation cost, hide technical parameters, edit fees Oct 17, 2023
@loonggamma loonggamma added this to the Minimal MW milestone Oct 18, 2023
@Thykof Thykof self-assigned this Oct 26, 2023
@Thykof Thykof linked a pull request Nov 9, 2023 that will close this issue
@Thykof Thykof closed this as completed Nov 21, 2023
@Thykof
Copy link
Contributor

Thykof commented Nov 21, 2023

QA ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants