Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Fix sonar lint CI #622

Open
Thykof opened this issue Aug 22, 2023 · 2 comments
Open

Refactor: Fix sonar lint CI #622

Thykof opened this issue Aug 22, 2023 · 2 comments

Comments

@Thykof
Copy link
Contributor

Thykof commented Aug 22, 2023

Refactor the code to fix all issues reported by solar lint: https://sonarcloud.io/summary/new_code?id=massalabs_thyra-plugin-wallet&branch=main

Code smells: https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&sinceLeakPeriod=true&id=massalabs_thyra-plugin-wallet
starting with priority: blocker, critical, major, minor

@loonggamma
Copy link
Contributor

loonggamma commented Sep 7, 2023

@gregLibert @Thykof need priority on this as it's tech issue. Is it P3 for Mainnet?

@gregLibert
Copy link
Contributor

@gregLibert @Thykof need priority on this as it's tech issue. Is it P3 for Mainnet?

We need to following code legacy oriented issues and start working on it after the ICO quest.

Futhermore this issue is huge and should split the different subject in multiple categories (meta issue)

@gregLibert gregLibert changed the title Refactor: Fix solar lint CI Refactor: Fix sonar lint CI Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants