Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_burn method from burn-internal doesn't adjust total supply #152

Open
leoloco opened this issue Mar 15, 2024 · 0 comments
Open

_burn method from burn-internal doesn't adjust total supply #152

leoloco opened this issue Mar 15, 2024 · 0 comments

Comments

@leoloco
Copy link
Contributor

leoloco commented Mar 15, 2024

Describe the bug

The internal method _burn from burn-internal.ts doesn't adjust total supply. The supply adjustment is done on burn.ts file. This is a bad practice because the burn method of burn.ts assumes that the caller's tokens are to be burned. However we shouldn't assume such a logic. It might be that some applications needs to burn from another account without allowance, i.e., perps, AMO stable coins, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant