Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong length for 64-bit integer using protobuf #379

Closed
MagicalTux opened this issue Dec 11, 2024 · 0 comments · Fixed by #383
Closed

Wrong length for 64-bit integer using protobuf #379

MagicalTux opened this issue Dec 11, 2024 · 0 comments · Fixed by #383

Comments

@MagicalTux
Copy link

All across the documentation, 64-bit integer using protobuf varint are mentioned with type written as:

From 1 byte (included) to 9 bytes (included)

This would be the case for up to 63 bits, however storing an extra 64th bit as protobuf varint (values 1 << 63 and above) would require one extra byte, so this should be corrected as:

From 1 byte (included) to 10 bytes (included)
@Ben-Rey Ben-Rey linked a pull request Dec 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant