-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No coins refunded after edit or delete #203
Comments
All of this could either be automated in the SC (the smart contract itself refunds the caller with any excess coins when updating or deleting) or in the frontend (after an update/delete operation, the front-end looks into the balance of the SC and proposes withdrawing if anything is left there) but that would be a bit heavier for the user |
cc
cc @SlnPons indeed solution two would add an extra operation to sign for the user (in both cli and frontend) |
Thanks guys! So I would go for the option 1: automated directly in the SC. I couldn't think of any use cases where this solution wouldn't fit. If you see any please share :) |
Needs to be tested |
@pivilartisant can you please update the status of this issue ? |
Before launching, we need to integrate on cli and frontend the coins refund implementing the withdraw function from the SC.
This should be pretty straight forward for the delete, but what about the edit ? technically since users are delete from storage, they should get refunded or should they request to be refunded ? How can we optimize this in the edit flow so users do not pay for what is already payed for ?
The text was updated successfully, but these errors were encountered: