Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cache creation #147

Open
3 tasks
thomas-senechal opened this issue Oct 25, 2024 · 2 comments
Open
3 tasks

Improve cache creation #147

thomas-senechal opened this issue Oct 25, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@thomas-senechal
Copy link
Member

thomas-senechal commented Oct 25, 2024

Context
Follows #145 (comment)

ATM, we create a new cache struct each time we need it. We could simplify that by having a singleton or having it stored in the API context.

Todo

  • Decide how to store the cache struct
  • Implement the changes
  • Ensure cache is still working properly
@SlnPons
Copy link
Collaborator

SlnPons commented Jan 3, 2025

Hey @thomas-senechal I'm not sure to understand the objective of this issue or what it solves. Could you elaborate please?

@thomas-senechal
Copy link
Member Author

Hey @thomas-senechal I'm not sure to understand the objective of this issue or what it solves. Could you elaborate please?

It's a technical issue, would make the code a tiny bit cleaner and improve a very little performances

Not a priority IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants