Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why the youtube: prefix #2

Open
danvega opened this issue May 1, 2019 · 1 comment
Open

Why the youtube: prefix #2

danvega opened this issue May 1, 2019 · 1 comment

Comments

@danvega
Copy link

danvega commented May 1, 2019 •
edited
Loading

Is there any reason you decided to go with the prefix `youtube: and use backticks to denote a youtube video? One approach you could do is if the video link matches a RegExp pattern and it's in its own paragraph you can just assume that we want to embed the video.

I am doing something similar for Twitter & CodeSandbox. If you're open to a pull request I could update this to work in a similar fashion. If not that is ok as well, I can just create a new plugin.
@markhoney
Copy link
Owner

Happy to accept a pull request - I just went with backticks because that was what the similar gatsby plugin does, and I was aiming for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danvega @markhoney