This repository has been archived by the owner on Mar 8, 2020. It is now read-only.

Refactor tests #12

Open

4 of 6 tasks

mark-wiemer opened this issue Aug 2, 2019 · 1 comment

Labels

refactor

Owner

mark-wiemer commented Aug 2, 2019 •

edited

Loading

Tests are currently not very granular and, in general, poorly organized.

Acceptance Criteria:

MainTests.assertCreatesGame becomes two methods: one for the scanner, one for CLA
Stay DRY with fixture-like functionality
Remove printing from passing tests (Remove printing from passing tests #41)
IoUtils interface ~~becomes instance-based, not static,~~ is improved (see IoUtils improvements #17)
Remove redundant tests (LevelTests is redundant, already tested within PlayTests)
Tests are at top of class

The text was updated successfully, but these errors were encountered:

mark-wiemer added the refactor label

mark-wiemer mentioned this issue

Remove printing from passing tests #41

Merged

Owner Author

mark-wiemer commented Aug 21, 2019

Really good information about parametrizing tests with JUnit 5: https://www.baeldung.com/parameterized-tests-junit-5

mark-wiemer mentioned this issue

Remove redundant tests #48

Merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.