-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathProhibitLargeSub.pm
121 lines (82 loc) · 2.42 KB
/
ProhibitLargeSub.pm
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
package Perl::Critic::Policy::Mardem::ProhibitLargeSub;
use utf8;
use 5.010;
use strict;
use warnings;
our $VERSION = '0.06';
use Readonly;
use Perl::Critic::Utils qw{ :severities :data_conversion :classification };
use base 'Perl::Critic::Policy';
Readonly::Scalar my $EXPL => q{Consider refactoring};
sub default_severity
{
return $SEVERITY_MEDIUM;
}
sub default_themes
{
return qw(complexity maintenance);
}
sub applies_to
{
return 'PPI::Statement::Sub';
}
sub supported_parameters
{
return (
{ 'name' => 'statement_count_limit',
'description' => 'The maximum statement count allowed.',
'default_string' => '20',
'behavior' => 'integer',
'integer_minimum' => 1,
},
);
}
sub violates
{
my ( $self, $elem, undef ) = @_;
my $s = $elem->find( 'PPI::Statement' );
if ( !$s ) {
return;
}
my $statement_count = @{ $s };
if ( $statement_count <= $self->{ '_statement_count_limit' } ) {
return;
}
my $desc;
if ( my $name = $elem->name() ) {
$desc = qq<Subroutine "$name" with high statement count ($statement_count)>;
}
else {
# never the case becaus no PPI::Statement::Sub
$desc = qq<Anonymous subroutine with high statement count ($statement_count)>;
}
return $self->violation( $desc, $EXPL, $elem );
}
1;
__END__
#-----------------------------------------------------------------------------
=pod
=encoding utf8
=head1 NAME
Perl::Critic::Policy::Mardem::ProhibitLargeSub - large subs as statement count
=head1 DESCRIPTION
This Policy counts the statements within a sub
(more precise the PPI::Statement's)
=head1 CONFIGURATION
The maximum acceptable Statement-Count can be set with the C<statement_count_limit>
configuration item. Any sub with a count higher than this number will generate a
policy violation. The default is 20.
An example section for a F<.perlcriticrc>:
[Mardem::ProhibitLargeSub]
statement_count_limit = 1
=head1 AFFILIATION
This policy is part of L<Perl::Critic::Mardem>.
=head1 AUTHOR
Markus Demml, [email protected]
=head1 LICENSE AND COPYRIGHT
Copyright (c) 2024, Markus Demml
This library is free software; you can redistribute it and/or modify it
under the same terms as the Perl 5 programming language system itself.
The full text of this license can be found in the LICENSE file included
with this module.
=cut