Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare with beni #6

Open
flying-sheep opened this issue Oct 6, 2023 · 3 comments
Open

Compare with beni #6

flying-sheep opened this issue Oct 6, 2023 · 3 comments

Comments

@flying-sheep
Copy link

Hi!

Any reason you didn’t choose to contribute to beni instead of making this? https://github.com/Quansight-Labs/beni

Seems like a cool project once it has some docs. How does Orko handle the name mapping between PyPI and conda? Does it use the cf-graph data? https://github.com/regro/cf-graph-countyfair

@marcelotrevisani
Copy link
Owner

Hi,
No, not at all. To be honest, I didn't even know about Beni. It is the first time that I heard about it.
The project was born as a result of a discussion that I had between some friends and we needed something like Orko. It is in early stages yet but it is managing to create the environment just fine. The last release of beni was in 2020, it seems to be a bit abandoned I think?

I still have some plans for the project to also call grayskull and generate the recipe to build the project.

In regards of the mapping between pypi and conda the user needs to map that. Indeed, it would be a nice addition to use the cf graph, that is something that can be added as a configuration in pyproject.toml to use it or disable it.

Thanks for your suggestion! If you have more features request please let me know :)

@flying-sheep
Copy link
Author

it seems to be a bit abandoned I think?

I think it’s mostly complete for its original scope (a CLI for what beni/orko do), but it could be expanded.

Ideally there would be only one tool, since the overlap is very high, but if not, the second best outcome is that orko builds on the lessons learned while beni was built.

that is something that can be added as a configuration in pyproject.toml to use it or disable it.

I don’t quite understand why anyone would want to disable it. You can just use the PyPI names, hope that the packages you use happen to have matching names, and watch things inevitably break, or you use the graph and things will probably go alright (it’s not perfect, but continuously maintained).

@marcelotrevisani
Copy link
Owner

There are a few cases, especially when handling private pypi channels or private conda channels that can arise, like name clashing. But in general, you are correct. That should be the default behaviour within an option to be able to disable it.

At the moment, I don't feel compelled enough to use Beni, because the scope of orko was not just to generate the environment.yml, and I am already using orko for my cases, so for me, it would be a lot of work and rework to move to something that is similar at a certain extent. Don't get me wrong, I think beni is great, but I would like to continue with this project and it might fulfil someone's needs as well. That is the reason that I put that public.

Lessons can be learned from beni, indeed. That is something I will take a look, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants