You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Convert the current pbf code to Typescript (same functionality)
This would certainly be a good idea.
Update the compiler to generate Typescript code ONLY,
Call the Typescript compiler programmatically to convert to ES6, common-js, ...
I don't think this is really necessary. In my pull request it only needs a few if statements around the parts which would add the type information into the generated code.
I would propose to keep it this way for the following reasons:
faster at runtime
less complexity as having to generate a temp file which is transpiled by TypeScript afterwards
less runtime dependencies (since TypeScript would only be a dev dependency)
I am interested in #107 that adds support for generating es6/typescript.
Also it seems like this repository would benefit from updates.
I would love to see the following happen:
What do you think ?
/cc @mourner
The text was updated successfully, but these errors were encountered: