Resolved issues with duplicate ROIs being created when switching sample #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
requested changes
Jan 27, 2025
| if roi_name is None: | ||
| self.view.spectrum_widget.roi_dict.clear() | ||
| for name in self.get_roi_names(): | ||
| for name in list(self.view.spectrum_widget.roi_dict.keys()): |
There was a problem hiding this comment.
Can we keep using self.get_roi_names()
samtygier-stfc
changed the title
samtygier-stfc
force-pushed
the
2473_sample_swicth_error
branch
from
249c511 to
de0a1d5
Compare
samtygier-stfc
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ROI management and synchronization in spectrum viewer
Issue Closes #2473
Description
do_remove_roito ensure proper removal of all ROIs or specific ROIs, keeping the table, model, and view in sync.Developer Testing
python -m pytest -vsAcceptance Criteria and Reviewer Testing
python -m pytest -vsKeyErroroccurs during ROI visibility updates.Documentation and Additional Notes