Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure workflow jobs have unique ids #2478

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

samtygier-stfc
Copy link
Collaborator

@samtygier-stfc samtygier-stfc commented Jan 27, 2025

Might help with #2477

Description

We currently have several workflows containing jobs with the id test

jobs:
  test:

https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_id says that job ids should be unqiue (though does not specify if this is per file or per project). This PR renames all the test to something more descriptive

Developer Testing

It is not possible to test locally.

Acceptance Criteria and Reviewer Testing

It is not possible to test locally.

  • Check that the github actions have run as expected on the PR.
  • Review the Github workflow syntax document and check that the change is sensible

Documentation and Additional Notes

Release notes not needed

When merging this PR. Check it the actions run on the merge queue. If so #2477 can be closed

@samtygier-stfc samtygier-stfc marked this pull request as ready for review January 27, 2025 12:01
@coveralls
Copy link

Coverage Status

coverage: 73.088%. remained the same
when pulling d7a8af6 on 2477-workflow-names
into b9a8fe9 on main.

Copy link
Collaborator

@JackEAllen JackEAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change improves test descriptions and there is no noticeable change to the workflows themselves that would cause them to fail. Happy to approve! 👍

@JackEAllen JackEAllen added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit 7bd8bed Jan 27, 2025
6 checks passed
@JackEAllen JackEAllen deleted the 2477-workflow-names branch January 27, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants