Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError when right clicking no items in Main Window TreeView #2470

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

MikeSullivan7
Copy link
Collaborator

@MikeSullivan7 MikeSullivan7 commented Jan 20, 2025

Issue

Close #2466

Description

When checking where in the tree view is being right clicked, if a stack is being selected then it will add the relevant options. If no stack is selected, then no right click options are added, so nothing happens.

Testing

make check

Acceptance Criteria

Load dataset in MI, right click the Tree view on a stack and in the whitespace below to check that the right click menu behaves as expected and that no errors occur.

@MikeSullivan7 MikeSullivan7 self-assigned this Jan 20, 2025
@MikeSullivan7 MikeSullivan7 marked this pull request as ready for review January 20, 2025 17:42
@coveralls
Copy link

coveralls commented Jan 20, 2025

Coverage Status

coverage: 73.088% (-0.03%) from 73.114%
when pulling 46fcad0 on 2466-right-click-treeview-error
into 1166cb4 on main.

@MikeSullivan7 MikeSullivan7 changed the title 2466 right click treeview error AttributeError when right clicking no items in Main Window TreeView Jan 21, 2025
Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue.

But also changes the logic of which options to show. It should show "Add/Replace" when clicking on the dataset.

@MikeSullivan7 MikeSullivan7 force-pushed the 2466-right-click-treeview-error branch from c34e396 to 01d8a3a Compare January 24, 2025 15:22
@MikeSullivan7 MikeSullivan7 force-pushed the 2466-right-click-treeview-error branch from 01d8a3a to 46fcad0 Compare January 24, 2025 15:42
Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue for me

@samtygier-stfc samtygier-stfc added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit 8fb608e Jan 24, 2025
8 checks passed
@samtygier-stfc samtygier-stfc deleted the 2466-right-click-treeview-error branch January 24, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError when right clicking Main Window TreeView
3 participants