Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added stack properties dialog in the Main Window #2465

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

MikeSullivan7
Copy link
Collaborator

@MikeSullivan7 MikeSullivan7 commented Jan 17, 2025

Issue

Closes #2368

Description

Added a custom dialog window which can be accessed by right clicking a stack in the main window and clicking on "Stack properties". This gives information on the stack e.g, Dataset name, File Path, Data type, Memory size, Shape, Log file. More information can be added if needed.

Testing

Make check

Acceptance Criteria

Load a dataset into MI and open the Stack Properties dialog window via the right click window. Check that all the information displayed is correct and that no errors occur

@MikeSullivan7 MikeSullivan7 force-pushed the 2368_stack_properties_menu branch 2 times, most recently from bb53906 to 0402a71 Compare January 20, 2025 17:04
@coveralls
Copy link

coveralls commented Jan 20, 2025

Coverage Status

coverage: 72.417% (-0.2%) from 72.603%
when pulling ee6bec3 on 2368_stack_properties_menu
into 0fff4f5 on main.

@MikeSullivan7 MikeSullivan7 marked this pull request as ready for review January 20, 2025 17:27
@MikeSullivan7 MikeSullivan7 self-assigned this Jan 20, 2025
@MikeSullivan7 MikeSullivan7 changed the title 2368 stack properties menu Added stack properties dialog in the Main Window Jan 20, 2025
Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get an error if I try to view properties of a 180 projection. I think a case is missing in _get_stack_data_type()

@samtygier-stfc samtygier-stfc force-pushed the 2368_stack_properties_menu branch from 6c6f22b to ee6bec3 Compare February 21, 2025 16:15
Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested locally. I did a squash, because there were quite a few commits.

@samtygier-stfc samtygier-stfc added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit 51e83d2 Feb 24, 2025
8 checks passed
@samtygier-stfc samtygier-stfc deleted the 2368_stack_properties_menu branch February 24, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack Properties Menu
3 participants