Add progress bar for binned RITS export #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
force-pushed
the
2028_rits_progress
branch
from
cd3b5f1 to
ab8a7a4
Compare
JackEAllen
reviewed
Feb 6, 2024
JackEAllen
approved these changes
Feb 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2028
Description
Call
save_rits_images()with an async task so that it runs in a separate thread with a progress bar.Testing & Acceptance Criteria
Test a 2D binned export with a large enough area to take at least a few seconds.
Check that the progress bar is displayed
Check that an error is handled with a message to the user, e.g. delete the export folder during export.
Documentation
Not needed