Resizable tof spectrum viewer #2026
Merged
+116
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,6 +41,8 @@ class SpectrumViewerWindowView(BaseMainWindowView): | |||
| bin_size_spinBox: QSpinBox | |||
| bin_step_spinBox: QSpinBox | |||
|
|
|||
| spectrumWidget: SpectrumWidget | |||
There was a problem hiding this comment.
Can the local name be in snake_case
spectrum_widget: SpectrumWidget
|
Looks good. Just needs a release note |
samtygier-stfc
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2025.
Description
In the
SpectrumWidgetfor the Spectrum Viewer, the image view and the spectrum plot have been separated into two separate widgets as this allows us to use a QSplitter to resize them in a comfortable way. The splitter is configured so that initially the image takes up 70% of the window and the spectrum plot takes 30%, but this can be easily configured. TheSpectrumWidgetclass now creates instances of theSpectrumPlotWidgetandSpectrumProjectionWidget. This refactoring required the unit tests to be modified.Testing
Check
make checkstill passes properly.Acceptance Criteria
Open some data in the Spectrum Viewer and see if the ToF plot can be easily resized and viewed. Make sure that the rest of the Spectrum Viewer still works as intended.
Documentation
Will be added to release notes.