-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1945 binning #2017
1945 binning #2017
Conversation
9493dde
to
da27677
Compare
Resolve Failures post rename of method to and additional argument of an ROI added to method
Ammend Failures in presenter tests to reflect changes made to presenter and model
da27677
to
d01a1b9
Compare
d01a1b9
to
833651b
Compare
833651b
to
e6fa371
Compare
Allow get_spectrum() to accept a name or an ROI (avoids complicating the presenter) Add test
The export requires it to be true. The view does not allow it the be false.
Avoid storing state and having to keep in sync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good and functions as expected, tests run successfully and errors appear as they should. I tested with the brass dataset.
I would suggest putting a progress bar if possible while the export is running like we would do with the operations. With a large ROI, the export can take a while and looks like the GUI is crashing (i.e. not responding).
Issue
Closes #1945
Description
Testing
save_rits_images()
to validate ROI size and sub-ROI position through each iteration as sub-ROI steps across and down each row and column of ROI.Acceptance Criteria
mantidimaging/gui/windows/spectrum_viewer/test
) passDocumentation
See:
docs/release_notes/next/feature-1945-export_binned_rits_data