Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1945 binning #2017

Merged
merged 12 commits into from
Feb 5, 2024
Merged

1945 binning #2017

merged 12 commits into from
Feb 5, 2024

Conversation

JackEAllen
Copy link
Collaborator

Issue

Closes #1945

Description

  • Connects Front-end RITS binned export to back-end
  • Bin RITS spectrum data taking a bin size and step size as input
  • Bin input validation
  • Refactor existing test
  • Write additional tests for new methods.

Testing

  • Manual Testing:
    • Check that the correct number of files are exported
    • Added print statements within save_rits_images() to validate ROI size and sub-ROI position through each iteration as sub-ROI steps across and down each row and column of ROI.
    • Checked output files
  • Reviewed automated tests.

Acceptance Criteria

  • Tests (mantidimaging/gui/windows/spectrum_viewer/test ) pass
  • Within the spectrum viewer, binned RITS data can now be exported to a folder.
  • Binned data is correct for standard deviation and propagated modes

Documentation

See: docs/release_notes/next/feature-1945-export_binned_rits_data

@coveralls
Copy link

coveralls commented Jan 23, 2024

Coverage Status

coverage: 75.671% (-0.01%) from 75.681%
when pulling b221299 on 1945_binning
into bd75526 on main.

@samtygier-stfc
Copy link
Collaborator

Forced push from da27677 to d01a1b9 to remove formatting changes on commits.

Allow get_spectrum() to accept a name or an ROI (avoids complicating the presenter)

Add test
The export requires it to be true.
The view does not allow it the be false.
Avoid storing state and having to keep in sync
@samtygier-stfc samtygier-stfc marked this pull request as ready for review January 31, 2024 08:22
Copy link
Collaborator

@MikeSullivan7 MikeSullivan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good and functions as expected, tests run successfully and errors appear as they should. I tested with the brass dataset.

I would suggest putting a progress bar if possible while the export is running like we would do with the operations. With a large ROI, the export can take a while and looks like the GUI is crashing (i.e. not responding).

@MikeSullivan7 MikeSullivan7 added this pull request to the merge queue Feb 5, 2024
Merged via the queue into main with commit 38d06f3 Feb 5, 2024
8 checks passed
@MikeSullivan7 MikeSullivan7 deleted the 1945_binning branch February 5, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RITS: Binning within Selected ROI
4 participants