Change ROI Colour #2015
Merged
Change ROI Colour #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
changed the title
|
samtygier-stfc
requested changes
Feb 5, 2024
Comment on lines
48
to
55
| color_dialog = QtWidgets.QColorDialog() | ||
| current_color = QtGui.QColor(*self._colour) | ||
| selected_color = color_dialog.getColor(current_color) | ||
|
|
||
| if selected_color.isValid(): | ||
| new_color = (selected_color.red(), selected_color.green(), selected_color.blue(), 255) | ||
| self.colour = new_color # Update the ROI color | ||
| self.sig_colour_change.emit(self._name, new_color) |
There was a problem hiding this comment.
Lets split this into is own method. So that asking for the colour is separated from triggering it.
Also, move the menu into the existing menu.
samtygier-stfc
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #1992
Description
This pull request addresses the issue reported in #1992. This pull request introduces an enhancement to the Spectrum Viewer, targeting the functionality around ROIs. Previously, users could not easily change the colour of an ROI within the viewer. With this update, I have implemented a right-click context menu for ROIs, providing users with an interface to select new colours. This enhancement improves user interaction with the Spectrum Viewer
Testing
Describe the tests that were used to verify your changes.
Acceptance Criteria
Right-clicked on various ROIs within the Spectrum Viewer to ensure the context menu appears consistently.
Selected different colours from the colour dialog and verified that the selected ROI updated to the new colour immediately.
Tested with multiple ROIs to ensure that changing the colour of one ROI does not affect others.
Documentation
Noted the changes in the appropriate file in docs/release_notes.