updated default values in Remove all stripes #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Update Default Values for "Remove all stripes" Filter - Resolves #2002
Description
This pull request updates the default values for the "Remove all stripes" filter in the Operations window. After evaluating feedback and conducting tests on typical datasets, it became evident that the current default settings were not optimal. The changes include:
Stripe Ratio: Updated from default to 3.
Large Stripe Kernel: Changed from default to 21.
Small Stripe Kernel: Adjusted from default to 7.
Dimensions of the Window: Set to 2 from the default value.
Testing
not needed
Acceptance Criteria
Reviewers should test the changes by applying the "Remove all stripes" filter on diverse datasets, particularly those where stripe interference is a known issue.
Documentation
The changes have been documented in the docs/release_notes under the upcoming release section.