Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI side for RITS export 2d binned mode #2010

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Conversation

samtygier-stfc
Copy link
Collaborator

@samtygier-stfc samtygier-stfc commented Jan 18, 2024

Issue

Work on #1945

Description

Add GUI part for 2d binned RITS export.
New option in Output Mode.
When 2D Binned is selected, then show Bin Size and Bin Step options.

Testing & Acceptance Criteria

Check that new output mode option is there, and new params show when it is selected

Documentation

Not needed yet

@samtygier-stfc samtygier-stfc marked this pull request as ready for review January 18, 2024 10:34
@coveralls
Copy link

coveralls commented Jan 18, 2024

Coverage Status

coverage: 75.681%. first build
when pulling b174d8c on 1945-rits-binning-gui
into 1c0bf00 on main.

Copy link
Collaborator

@JackEAllen JackEAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JackEAllen JackEAllen added this pull request to the merge queue Jan 22, 2024
Merged via the queue into main with commit 6f47823 Jan 22, 2024
8 checks passed
@JackEAllen JackEAllen deleted the 1945-rits-binning-gui branch January 22, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants