-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update Pull request template (#2464)
- Loading branch information
Showing
3 changed files
with
42 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,31 @@ | ||
### Issue | ||
|
||
*Close or ref the associated ticket, e.g. Closes #84* | ||
<!-- Close or ref the associated ticket, e.g. --> | ||
## Issue Closes #<ISSUE> | ||
|
||
### Description | ||
|
||
*Add a description of the changes made*. | ||
<!-- Add a description of the changes made. --> | ||
|
||
### Developer Testing | ||
|
||
<!-- Describe the tests that were used to verify your changes --> | ||
- I have verified unit tests pass locally: `python -m pytest -vs` | ||
- ... | ||
|
||
### Testing | ||
### Acceptance Criteria and Reviewer Testing | ||
|
||
*Describe the tests that were used to verify your changes*. | ||
<!-- Validation checks the reviewer should make and step by step instructions for how the reviewer should test including any necessary environment setup (Reviewer should tick off each check. Reviewer may also perform additional tests--> | ||
- [ ] Unit tests pass locally: `python -m pytest -vs` | ||
- [ ] ... | ||
|
||
### Acceptance Criteria | ||
### Documentation and Additional Notes | ||
|
||
*How should the reviewer test your changes*? | ||
<!-- Please un-comment any of the below checkboxes applicable for your PR. This could be updated release notes, sphinx documentation, or screenshot tests. | ||
Please also add any additional notes that may be helpful to the reviewer here including screenshots if necessary --> | ||
|
||
### Documentation | ||
<!-- - [ ] Release Notes have been updated | ||
- [ ] Sphinx documentation has been updated | ||
- [ ] Screenshot tests have been updated | ||
- [ ] **Before merge for developer:** Resolve the change on applitools by, creating a new baseline for test and verify that the tests pass. | ||
- [ ] **After merge for reviewer:** Go to [Applitools compare and merge page](https://eyes.applitools.com/app/merge/), select all changes and merge dev branch to default branch | ||
- [ ] **After merge for reviewer:** Verify that other PR's screenshot tests do not start to fail (See [Applitools baselines](https://eyes.applitools.com/app/baselines) for more info) --> | ||
|
||
*How have you changed the documentation to reflect your changes? All changes should be noted in the appropriate file in docs/release_notes* |