Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlasmaShell replaces the DNF Dragora logo with the Wayland logo in the Task Manager plasmoid. #236

Open
RokeJulianLockhart opened this issue Jun 11, 2024 · 8 comments

Comments

@RokeJulianLockhart
Copy link

RokeJulianLockhart commented Jun 11, 2024

Might be related to #169 (comment).

Reproduction Screencast

Screencast_20240611_154813.webm

Demonstration Screenshot

Screenshot_20240611_155156

@anaselli
Copy link
Collaborator

As far as I can say icon path is set here and overwritten by configuration file here.
libyui SetApplicationIcon is called here
That is pretty hard coded so i cannot say why you see a different icon

@RokeJulianLockhart RokeJulianLockhart changed the title PlasmaShell relaces DNF Dragora logo with Wayland logo in taskbar plasmoid. PlasmaShell replaces the DNF Dragora logo with the Wayland logo in the Task Manager plasmoid. Jun 12, 2024
@RokeJulianLockhart
Copy link
Author

RokeJulianLockhart commented Jun 12, 2024

#236 (comment)

@anaselli, does discuss.kde.org/t/2468/2 provide any actionable information?

@anaselli
Copy link
Collaborator

@RokeJulianLockhart I don't know, honestly. Can you tell me where are you testing wayland? I mean Fedora rawhide or...
I maybe try to do some tests there and see if i can change anything.

But if it is a matter of libyui QT version call is here while the Gtk one is here
if something has to changed there, is a libyui issue. So if you have the clue to do some tests, please go on, any helps is more than welcome :)

@RokeJulianLockhart
Copy link
Author

RokeJulianLockhart commented Jun 12, 2024

#236 (comment)

@anaselli, apologies - I should have provided system information with the report. I'm using Fedora-KDE-Live-x86_64-40, so the Fedora 40 (so not Rawhide, but a stable release, and non-beta by now) KDE Spin. kinfo reports:

Operating System: Fedora Linux 40  
KDE Plasma Version: 6.0.5  
KDE Frameworks Version: 6.3.0  
Qt Version: 6.7.1  
Kernel Version: 6.8.12-300.fc40.x86_64 (64-bit)  
Graphics Platform: Wayland  
Processors: 12 × AMD Ryzen 5 7600X 6-Core Processor  
Memory: 30.5 GiB of RAM  
Graphics Processor: AMD Radeon RX 5700  
Manufacturer: ASRock  
Product Name: X670E Taichi

The sole alternative project using libyui that I know of is YaST, but I can't test DNFDragora and YaST on the same OS installation. Do you know of any other libyui projects?

@anaselli
Copy link
Collaborator

anaselli commented Jun 13, 2024

our Manatools. ATM an alpha version of manafirewall, and isodumper, you need to have libyui-mga plugins to make them working. I would avoid YAST just because Suse can hack their library to make it working expecially for Qt.
We can provide patches though and if that does not break things they are quickly accepted, libyui-Gtk is managed by me for the most but approved by suse people.
I think though that a simple libyui use case application in python (maybe using python-manatools) and in c++ (just a dialog with a title and an icon should be enough) should be easy to debug to understand where the problem lays

@Merrit
Copy link

Merrit commented Sep 3, 2024

In Wayland apps are identified differently than they were on X11. libyui is lacking the methods to set this for Wayland currently.

Qt needs to call QGuiApplication::setDesktopFileName.

GTK needs to call g_set_prgname.

They should be set to the same name as the desktop file, usually the reverse DNS name; eg. org.mageia.dnfdragora in this case, most likely.

We can inspect the window properties on KDE with KWin debug console:

image

image

Relevant fields here would be the desktopFileName, resourceClass and resourceName - which are currently all showing python rather than the DNS identifier on my system. GNOME can do something similar with Looking Glass.

@Conan-Kudo
Copy link
Member

So this should be filed against libyui...

@RokeJulianLockhart
Copy link
Author

#236 (comment)

@Conan-Kudo, filed at libyui/libyui/issues/115.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants