Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing icons for comps categories and groups #2

Closed
kkofler opened this issue Nov 15, 2016 · 0 comments
Closed

Missing icons for comps categories and groups #2

kkofler opened this issue Nov 15, 2016 · 0 comments

Comments

@kkofler
Copy link
Contributor

kkofler commented Nov 15, 2016

Using revision bb6edcf.

Icons for the groups are AWOL on Fedora. The paths it tries to use are for Mageia. So I get only warnings on the console about not found icons and no icons.

https://fedorahosted.org/comps/ explains how icons for comps groups should be looked up:

Groups have an icon associated with them. These icons come from the comps-extras package; icons are read from /usr/share/pixmaps/comps/<group-id>.png. If an icon does not exist for a group id, the one for the category that the group is in is used.

I also have a /usr/share/pixmaps/comps/uncategorized.png that can be used as a fallback if the icon is missing.

Note, however, that to properly implement this, we need the internal IDs of the categories, which dnfdaemon currently does not return anywhere: manatools/dnfdaemon#9 .
@kkofler kkofler mentioned this issue Nov 15, 2016
Closed
kkofler added a commit to kkofler/dnfdragora that referenced this issue Nov 16, 2016
@kkofler
Improve comps group support
072b4bc 
New file dnfdragora/compsicons.py, similar to groupicons.py, but for
comps.

New tool tools/gen-comps-category-list.sh: Generates a map from category
name to ID for dnfdragora/compsicons.py, as a workaround for
manatools/dnfdaemon#9.

dnfdragora/ui.py (mainGui._getAllGroupIDList): Remember the UI names for
                                               each ID in an
                                               id_to_name_map.
                 (mainGui._fillGroupTree): Handle comps separately, use
                                           compsicons.py to get the
                                           icons (manatools#2) and use the
                                           id_to_name_map to get the UI
                                           name (manatools#3).

Fixes manatools#2.
Fixes manatools#3.
kkofler added a commit to kkofler/dnfdragora that referenced this issue Nov 16, 2016
@kkofler
Improve comps group support
7e7d903 
New file dnfdragora/compsicons.py, similar to groupicons.py, but for
comps.

New tool tools/gen-comps-category-list.sh: Generates a map from category
name to ID for dnfdragora/compsicons.py, as a workaround for
manatools/dnfdaemon#9.

dnfdragora/ui.py (mainGui._getAllGroupIDList): Remember the UI names for
                                               each ID in an
                                               id_to_name_map.
                 (mainGui._fillGroupTree): Handle comps separately, use
                                           compsicons.py to get the
                                           icons (manatools#2) and use the
                                           id_to_name_map to get the UI
                                           name (manatools#3).

Fixes manatools#2.
Fixes manatools#3.

The only remaining issue is that the UI names are not translated, which
I filed as manatools/dnfdaemon#10 because Yumex-DNF is also affected (and
thus it is clearly dnfdaemon's fault).
@kkofler kkofler mentioned this issue Nov 16, 2016
Merged
Conan-Kudo pushed a commit that referenced this issue Nov 16, 2016
@kkofler @Conan-Kudo
Improve comps group support
1e34f1a 
New file dnfdragora/compsicons.py, similar to groupicons.py, but for
comps.

New tool tools/gen-comps-category-list.sh: Generates a map from category
name to ID for dnfdragora/compsicons.py, as a workaround for
manatools/dnfdaemon#9.

dnfdragora/ui.py (mainGui._getAllGroupIDList): Remember the UI names for
                                               each ID in an
                                               id_to_name_map.
                 (mainGui._fillGroupTree): Handle comps separately, use
                                           compsicons.py to get the
                                           icons (#2) and use the
                                           id_to_name_map to get the UI
                                           name (#3).

Fixes #2.
Fixes #3.

The only remaining issue is that the UI names are not translated, which
I filed as manatools/dnfdaemon#10 because Yumex-DNF is also affected (and
thus it is clearly dnfdaemon's fault).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kkofler