Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anyoneplaying command #10

Closed
invicta-nz opened this issue Jun 6, 2020 · 9 comments
Closed

Anyoneplaying command #10

invicta-nz opened this issue Jun 6, 2020 · 9 comments
Labels
enhancement New feature or request
Milestone

Comments

@invicta-nz
Copy link
Collaborator

New command ;anyoneplaying that loops through all configured servers issuing ServerInfo and RefreshList command

Allow anyone to issue this command

@invicta-nz invicta-nz added the enhancement New feature or request label Jun 6, 2020
@makupi makupi added this to the v0.2.0 milestone Jun 6, 2020
@makupi
Copy link
Owner

makupi commented Jun 6, 2020

For clarification, do you want something that just outputs all the ServerInfo and RefreshList commands formatted like they are now?
Or something like ;servers but with the amount of players listed next to it per server?

@invicta-nz
Copy link
Collaborator Author

Well if I was doing it would I just loop through the outputs and dump them out formatted as-is and that would be good enough cause I am lazy like that. Someone more skilled might pull together that into a report format with mapID (name in future), numbers and then names of players per server.

@makupi
Copy link
Owner

makupi commented Jun 6, 2020

Only downside of doing it in ;servers would be that the command would take longer (in case someone just wants to get the "tags")..
So maybe another command that posts like a table with NAME - MAP - PLAYERS

@invicta-nz
Copy link
Collaborator Author

Ah, yeah, don't do it in servers. Want it to be it's own command.

@invicta-nz
Copy link
Collaborator Author

Starting to load my bot up with other people's servers for testing until we let them run their own. Can anyoneplaying get some filtering when it is written. Could either be a config file that lists servers, or perhaps even better a new line in the servers.json config that tags the server to be in the output of this command.

@invicta-nz
Copy link
Collaborator Author

I am thinking now an optional line in servers.json for anyoneplaying:group. So calling ;anyoneplaying apac will get my servers (tagged as such)

@invicta-nz
Copy link
Collaborator Author

;anyoneplaying breaks when loading info from this incompletely populated steam page:
https://steamcommunity.com/sharedfiles/filedetails/?id=2111731598

Jun 25 09:47:41 Pavlov-syd pipenv[377]: 2020-06-25 09:47:41,809 root         INFO     9101 - RCON _recv data='{\n\t"ServerInfo":\n\t{\n\t\t"MapLabel": "UGC2111731598",\n\t\t"GameMode": "SND",\n\t\t"ServerName": "[ArcticVR][NA-WEST]Summer SND1",\n\t\t"RoundState": "Started",\n\t\t"PlayerCount": "0/10"\n\t}\n}\r\n'
Jun 25 09:47:42 Pavlov-syd pipenv[377]: 2020-06-25 09:47:42,721 root         ERROR    Getting map label failed with list index out of range

Looks like when it gets this error, it stops looping and exits. Likely a won't fix sort of error for right now as it is likely edge case and map dev will resolve by adding image to project.

@makupi
Copy link
Owner

makupi commented Jun 25, 2020

Ah okay, I'll still add some error handling to catch the issue.

@makupi
Copy link
Owner

makupi commented Jun 25, 2020

Closing this through #42 - Filtering will be done through #39

@makupi makupi closed this as completed Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants