Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Banner image size - too small? Make taller or add a new size for 'section'? #168

Closed
JiveDig opened this issue Mar 15, 2018 · 2 comments
Closed

Banner image size - too small? Make taller or add a new size for 'section'? #168

JiveDig opened this issue Mar 15, 2018 · 2 comments

Comments

@JiveDig
Copy link
Collaborator

JiveDig commented Mar 15, 2018

Banner looks really bad when sections are really tall. And if/when this gets added #167 we're screwed. We either need a new size or to make it taller.

Maybe a new size and check on what section height setting is and choose banner or section?

Also, we should probably (definitely?) have an image_size parameter in section.
@JiveDig
Copy link
Collaborator Author

JiveDig commented Mar 15, 2018

Yes, definitely need a new image size param in section.

@JiveDig
Copy link
Collaborator Author

JiveDig commented Feb 6, 2019

Been done.

@JiveDig JiveDig closed this as completed Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JiveDig