Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications by window #517

Open
hunterlester opened this issue Jan 9, 2019 · 2 comments
Open

Notifications by window #517

hunterlester opened this issue Jan 9, 2019 · 2 comments
Labels
blocked bug enhancement
Milestone
Next

Comments

@hunterlester
Copy link
Contributor

Per #450:

When I open http/s links, shows the Detected http/s protocol notification now and closes the particular tab successfully. But after closing the notification, Whenever I open a New Window from file menu, that window also shows the same notification. but closing the notification from the new window, it doesn't seem to be an issue after that.

Should notifications be handled by window ID?
@hunterlester hunterlester added this to the next milestone Jan 9, 2019
@hunterlester hunterlester mentioned this issue Jan 9, 2019
Closed
@joshuef
Copy link
Collaborator

joshuef commented Jan 10, 2019

Hmmmm, I guess it depends.

There are situations where we'd want both right? (disconnect for all windows eg). But, in that case we'd want dismissal to work across all windows also...

@joshuef joshuef modified the milestones: 0.11.1, Next Jan 17, 2019
@joshuef joshuef mentioned this issue Feb 26, 2019
Closed
@joshuef
Copy link
Collaborator

joshuef commented Apr 29, 2019

Marking as blocked until we have #593

@manavbp manavbp mentioned this issue Oct 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked bug enhancement
Projects
None yet
Milestone
Next
Development

No branches or pull requests
2 participants
@joshuef @hunterlester