Reopen last tab doesn't focus on newly opened tab #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuef
requested changes
Jul 2, 2019
joshuef
requested changes
Jul 5, 2019
| .click( `.${CLASSES.CLOSE_TAB}` ) | ||
| .expect( Selector( `.${CLASSES.TAB}` ).count ) | ||
| .eql( 1 ); | ||
|
|
There was a problem hiding this comment.
Some checks on the tab/address bar contents are worthwhile here, I think. All we're checking now is that there are 2 tabs. Not that the one we just closed was reopened...
|
Closing due to PR pruning - this can be picked up again at a later date if required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #484
QA:
To test this PR-