Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reopen last tab doesn't focus on newly opened tab #484

Open
calumcraig opened this issue Dec 18, 2018 · 3 comments
Open

Reopen last tab doesn't focus on newly opened tab #484

calumcraig opened this issue Dec 18, 2018 · 3 comments
Labels
bug help wanted

Comments

@calumcraig
Copy link

Steps to reproduce:

  1. Open SAFE browser with multiple (eg 5) tabs open.
  2. Close one tab.
  3. Select "Reopen last tab" from OR use CTRL + SHFT + T to open previously closed tab.

Expected:
Focus will change to newly reopened tab and bring it to the front of the browser window.

Actual:
Focus stays on currently open tab - reopened tab is in the "background" of the browser window. See attached document for screenshots:
https://docs.google.com/document/d/1jQUS65RJ0drXJ9elxnD9CsIdF0LiHBL-RXoiqTkCHbI/edit
@calumcraig calumcraig added the bug label Dec 18, 2018
@hunterlester hunterlester self-assigned this Dec 28, 2018
@hunterlester hunterlester added this to the next milestone Dec 28, 2018
@hunterlester hunterlester mentioned this issue Dec 28, 2018
Merged
@calumcraig
Copy link
Author

Testing this on latest Master branch. Focus returns to the newly reopened tab when using either CTRL + SHIFT + T or the menu option.
image
image
image
image

@hunterlester hunterlester mentioned this issue Jan 25, 2019
Open
@calumcraig
Copy link
Author

This behaviour can be seen again in v0.14.0. Reopening the issue.

@calumcraig calumcraig reopened this Jun 28, 2019
@calumcraig
Copy link
Author

Moved this back to triage on the project board.

@calumcraig calumcraig removed this from the 0.11.1 milestone Jul 1, 2019
@manavbp manavbp mentioned this issue Jul 2, 2019
Closed
@hunterlester hunterlester removed their assignment Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reopen last tab doesn't focus on newly opened tab manavbp/safe_browser
4 participants
@joshuef @hunterlester @S-Coyle @calumcraig