No safe browser icon on Linux

[S-Coyle]

Noticed when testing #373 that the safe icon was present in Windows and OSX, however not in Linux. Tested both the branch for adding icons to Peruse Safe Browser as per #373 , as well as the most recent Beaker Safe Browser release (https://github.com/maidsafe/safe_browser/releases/tag/0.10.2) - no icon appearing on Linux.

My linux VM = ubuntu 16.04 LTS

Icon showing =

[hunterlester]

Setting this task aside until I can find another clue as to the issue.

One trial was the possibility of needing to explicitly set icon in BrowserWindow options: https://github.com/electron-userland/electron-packager/blob/master/docs/api.md#icon

Another trial was possible needing to move icons directory into a build directory: https://www.electron.build/icons

Both to no avail.

[hunterlester]

Currently looking into necessary desktop entry: https://developer.gnome.org/integration-guide/stable/desktop-files.html.en

https://www.electron.build/configuration/linux

Thinking this is the case because there is no Icon entry in the desktop file:

   [Desktop Entry]
   Type=Application
   Name=Peruse-Browser
   Exec="/home/hunterlester/safe/dev/browser/node_modules/electron/dist/electron" "/home/hunterlester/safe/dev/browser/app/main.js" %u
   Terminal=false
   MimeType=x-scheme-handler/safe
   NoDisplay=true

[hunterlester]

This issue should have been fixed with electron-builder@v20.26.0.
Attempted with v20.28.4, to no avail.
Although perhaps I have misunderstood and this is a fix only for Ubuntu 18 LTS

[hunterlester]

Upgrading electron-builder on Ubuntu 18 does not resolve the issue either.

[joshuef]

@shriram2301 can you post what you've tried here so we have record of what's been tried, and link to the electron builder issue.

[shriram2301]

@joshuef sure thing.
So far, I have tried the following approaches:
- remove the .png file and try packaging. For Linux in the absence of the png icon, it converts the .icns icon file for macOS and uses it as app icon. This didn't work.

• I gave the app directory and link explicitly in package.json and tried packaging both normally and explicitly with --linux as the params by adding a new script. This also didn't work.
• another solution suggested was to move the set permissions for the files with size name in /icons directory to 644 by using chmod 644 * . This also didn't work.
• In addition, I tried a host of restructuring the folders and their structure to no avail.
• I also tried downgrading electron-builder to older version as well as upgrading to latest release this didn't work as well.
• Finally, I tried moving the resources into build folder like @hunterlester had done previously. That also didn't work. But adding icon in Browser Config now shows icon in dev mode.

The link to the issue is:
electron-userland/electron-builder#2577

There are other projects which use electron-builder that have the same issue.

[calumcraig]

I have been able to resolve this on my local machine (Linux Mint 19 Cinnamon) by creating a .desktop file for the SAFE browser in:

/usr/share/applications/SAFE Browser.desktop

I had to manually copy an image file into the source folder for the icon then reference it:

[Desktop Entry]
Encoding=UTF-8
Exec=/home/calum/Documents/safe-browser-1.0.0-rc.2/safe-browser-v0.7.0-linux-x64/safe-browser
Icon=/home/calum/Documents/safe-browser-1.0.0-rc.2/safe-browser-v0.7.0-linux-x64/safenetworklogo.jpeg
Type=Application
Terminal=false
Comment=SAFE Browser
Name=SAFE Browser
GenericName=safe-browser
StartupNotify=false
Categories='Network';'Web Browser';

I was doing this to create a launcher in my menu for the browser but was able to add the icon image file at the same time.

Edit - this workaround only works for when the browser is launched from the menu launcher that the .desktop file configures. If I click on a safe link which opens the browser there is no icon as described in the original issue.

[calumcraig]

Just an observation - I built another (non SAFE) Electron app today and when it is running I get the same thing as the browser - a generic icon in the taskbar. This app doesn't officially support Linux though I guess the developer hasn't considered this.