Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error bubble at form validation #22

Open
Thierry61 opened this issue Apr 11, 2017 · 5 comments
Open

No error bubble at form validation #22

Thierry61 opened this issue Apr 11, 2017 · 5 comments

Comments

@Thierry61
Copy link

Operation System: Windows 10
Beaker Version: 0.4.3

If an invalid string is entered in an input element with a pattern, then an error bubble doesn’t appear. This works fine with Google Chrome 57.0.2987.133 and Microsoft Edge 38.14393.0.0 but not with Beaker 0.4.3.

See input field in safe://constellations2 or this codepen in clear net for comparison with Chrome or Edge.

@hitman401
Copy link

Hi @Thierry61, hope this issue is resolved in the latest release. If you find the issue still prevailing, please do reopen this issue again. Thanks!

@Thierry61
Copy link
Author

Hi Krishna. Sorry, but error bubble still doesn’t work with SAFE Browser 0.4.0.

Here some screen shots in the same codepen in clear net:

  • SAFE Browser (NOK):
    safe browser - no error bubble

  • Chrome (OK):
    chrome - error bubble

  • Edge (OK):
    edge - error bubble

Note: You tell me to reopen the issue again but I don't have the privilege for that.

@hitman401 hitman401 reopened this Aug 6, 2017
@hitman401
Copy link

Thanks for the detailed information. We will look into this issue.

@hunterlester
Copy link
Contributor

Known issue in electron: electron/electron#1043
@joshuef Do we want to implement support for HTML5 form validation or document this as something that web app developers must implement?
Thinking about what we'd have to do...something like in the Tab component, query for input elements with a pattern attribute and add an invalid event listener. On invalid event I guess a modal or something like a SnackBar could be rendered.

@joshuef
Copy link
Collaborator

joshuef commented Nov 15, 2018

@joshuef Do we want to implement support for HTML5 form validation or document this as something that web app developers must implement?

Hmm, I think we certainly should do this.

Once we've antD setup and we've more stable UI components this should be simpler (I wouldnt do this with a custom tooltip component, nor use nessie as we'll likely deprecate that soon enough.

@hunterlester hunterlester removed their assignment Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants