Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Invalid auth middleware clearTimeout implementation #4377

Open
1 of 8 tasks
rafalslowik opened this issue Jan 22, 2025 · 1 comment
Open
1 of 8 tasks

[bug]: Invalid auth middleware clearTimeout implementation #4377

rafalslowik opened this issue Jan 22, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@rafalslowik
Copy link

rafalslowik commented Jan 22, 2025

Describe the bug

Invalid auth middleware clearTimeout implementation. Function clearTimeout accept number type, not array as is.

To reproduce

Steps to reproduce the behavior:

  • Impossible to reproduce. Found it when checking how function work.

Expected behavior

Cleared timeout to avoid memory leak.

Screenshots

Image

Possible solutions

Use array destructuring on Map to get valid number type field to clear interval.

Image

Debug Report

Please complete the following device information:

Please let us know what packages this bug is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa
@rafalslowik rafalslowik added the bug Something isn't working label Jan 22, 2025
Copy link

m2-assistant bot commented Jan 22, 2025

Hi @rafalslowik. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant