Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On higher than 4K screens, the right-half of the screen is blocky #734

Open
Tatsh opened this issue Dec 4, 2024 · 11 comments
Open

On higher than 4K screens, the right-half of the screen is blocky #734

Tatsh opened this issue Dec 4, 2024 · 11 comments

Comments

@Tatsh
Copy link

Tatsh commented Dec 4, 2024

Demonstration full size image

Notice the wood blocks. The left side is fine but the right-side is lower resolution:

image

Happens for every game.

I checked the electroShock demo on WebGL samples and the same behaviour does not occur. Other demos on the site are too low resolution to confirm anything.

electroShock screenshot

@magcius
Copy link
Owner

magcius commented Dec 5, 2024

What antialiasing method are you using?

@Tatsh
Copy link
Author

Tatsh commented Dec 5, 2024

FXAA.

If I switch to 4x FXAA it seems to be working fine. None also works.

@magcius
Copy link
Owner

magcius commented Dec 5, 2024

Wait, so FXAA works or doesn't work? Did you mean MSAA for one of those?

@Tatsh
Copy link
Author

Tatsh commented Dec 5, 2024

FXAA does not work.

4x MSAA does work. As well as None.

@magcius
Copy link
Owner

magcius commented Dec 5, 2024

That does sound strange to me. I wonder if textureOffset is broken on >4k textures on your GPU for some reason? If you have an ability to check out and run noclip locally, try changing this #if 1 here to an #if 0. https://github.com/magcius/noclip.website/blob/master/src/gfx/passes/FXAA.ts#L27

@Tatsh
Copy link
Author

Tatsh commented Dec 5, 2024

Confused on how to start it:

 $ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
 $ pnpm start

> @jstpierre/noclip.website@ start /home/tatsh/dev/noclip.website
> pnpm run build:rust && cross-env NODE_ENV=development rspack dev


> @jstpierre/noclip.website@ build:rust /home/tatsh/dev/noclip.website
> wasm-pack build -t web rust

Error: `cargo metadata` exited with an error:     Updating crates.io index
error: failed to select a version for `env_logger`.
    ... required by package `polymorph v0.1.0 (https://github.com/wgreenberg/polymorph#2379ecce)`
    ... which satisfies git dependency `polymorph` (locked to 0.1.0) of package `noclip-support v0.0.0 (/home/tatsh/dev/noclip.website/rust)`
versions that meet the requirements `^0.11.3` (locked to 0.11.5) are: 0.11.5

the package `polymorph` depends on `env_logger`, with features: `anstream` but `env_logger` does not have these features.
 It has an optional dependency with that name, but that dependency uses the "dep:" syntax in the features table, so it does not have an implicit feature with that name.


failed to select a version for `env_logger` which could resolve this conflict

Caused by: `cargo metadata` exited with an error:     Updating crates.io index
error: failed to select a version for `env_logger`.
    ... required by package `polymorph v0.1.0 (https://github.com/wgreenberg/polymorph#2379ecce)`
    ... which satisfies git dependency `polymorph` (locked to 0.1.0) of package `noclip-support v0.0.0 (/home/tatsh/dev/noclip.website/rust)`
versions that meet the requirements `^0.11.3` (locked to 0.11.5) are: 0.11.5

the package `polymorph` depends on `env_logger`, with features: `anstream` but `env_logger` does not have these features.
 It has an optional dependency with that name, but that dependency uses the "dep:" syntax in the features table, so it does not have an implicit feature with that name.


failed to select a version for `env_logger` which could resolve this conflict

@magcius
Copy link
Owner

magcius commented Dec 5, 2024

According to this issue with a similar error message, it's caused by an old version of Cargo or rust? Try updating. I'm far from a Rust expert on this though. extrawurst/gitui#2094 (comment)

@Tatsh
Copy link
Author

Tatsh commented Dec 5, 2024

I got it to work with Rustup instead of using my system Rust.

The same issue occurs when I set that line to #if 0.

image

The lighter side is the break point at 3841 px. Everything past that point will appear blocky (though it can be hard to tell with SM64 DS data).

@Tatsh
Copy link
Author

Tatsh commented Dec 6, 2024

Another person was able to reproduce this by stretching the window to be large enough across a few monitors. It only affects Chrome.

image

@magcius
Copy link
Owner

magcius commented Dec 6, 2024

Yeah, it's either a Chrome bug or a Linux graphics driver bug. Not sure which. I'd file a bug with your drivers first, and then see where it goes from there.

@Tatsh
Copy link
Author

Tatsh commented Dec 17, 2024

Reported here: https://issues.chromium.org/issues/384531049

It is a Chromium issue because Firefox (while slow for me) works properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants