Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The [[nodiscard]] attribute should be used more often #99

Closed
madmann91 opened this issue Feb 1, 2025 · 0 comments
Closed

The [[nodiscard]] attribute should be used more often #99

madmann91 opened this issue Feb 1, 2025 · 0 comments
Assignees
@madmann91
Labels
enhancement New feature or request

Comments

@madmann91
Copy link
Owner

See title.
@madmann91 madmann91 added the enhancement New feature or request label Feb 1, 2025
@madmann91 madmann91 self-assigned this Feb 1, 2025
madmann91 added a commit that referenced this issue Feb 3, 2025
@madmann91
Add nodiscard attributes in various key places (issue #99)
8601285 
Warning: This change is breaking the API, since the precomputed triangle
intersection function now no longer modifies the ray in place. The
traversal routine is expected to update the ray `tmax` value in order to
achieve good performance.
madmann91 added a commit that referenced this issue Feb 3, 2025
@madmann91
Add nodiscard attributes in various key places (issue #99)
fbdc596 
Warning: This change is breaking the API, since the precomputed triangle
intersection function now no longer modifies the ray in place. The
traversal routine is expected to update the ray `tmax` value in order to
achieve good performance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madmann91 madmann91

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@madmann91