Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(malachite): tendermint concensus #475

Open
1 of 16 tasks
Tracked by #419
Trantorian1 opened this issue Jan 24, 2025 · 0 comments · May be fixed by #477
Open
1 of 16 tasks
Tracked by #419

feat(malachite): tendermint concensus #475

Trantorian1 opened this issue Jan 24, 2025 · 0 comments · May be fixed by #477
Labels
feature Request for new feature or enhancement node Related to the full node implementation research Research and exploration required before implementation sequencer Related to the sequencing logic and implementation

Comments

@Trantorian1
Copy link
Collaborator

Is there an existing issue?

  • I have searched the existing issues

Motivation

With the migration to p2p block production in Starknet, we need to support the chain's upcoming consensus mechanism. This PR outlines the step to integrating Malachite, a Tendermint consensus engine developed by Informal Systems, into the codebase.

Warning

This issue requires #463 to be fully implemented as it requires p2p sync capabilites to be tested.

Request

Integration of Malachite into the codebase.

Solution

Steps to integration.

  • Basic boilerplate

  • Proposal

    • Proposer and proposer sets.
    • Signing propositions
    • Validation: integration with the current block validation pipeline.

  • Events (integration with the low-level engine)

    • Proposal
    • Prevote
    • Precommit
    • Block storage

  • Testing

    • Unit testing
    • Simulation testing and Proptesting

Note

It might be worth looking into ways to simulate the db during tests. This can be a good starting point for that.

Are you willing to help with this request?

Yes!
@Trantorian1 Trantorian1 added feature Request for new feature or enhancement node Related to the full node implementation research Research and exploration required before implementation sequencer Related to the sequencing logic and implementation labels Jan 24, 2025
@Trantorian1 Trantorian1 moved this to In progress in Madara Jan 24, 2025
This was referenced Jan 24, 2025
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Request for new feature or enhancement node Related to the full node implementation research Research and exploration required before implementation sequencer Related to the sequencing logic and implementation
Projects
Madara
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(malachite): Tendermint consensus support madara-alliance/madara
1 participant
@Trantorian1