Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference between strict and non-strict bold and italic #11

Open
DivineDominion opened this issue Jul 21, 2017 · 1 comment
Open

Difference between strict and non-strict bold and italic #11

DivineDominion opened this issue Jul 21, 2017 · 1 comment

Comments

@DivineDominion
Copy link
Contributor

There's a strict bold pattern matched first, then a non-strict applied afterwards. Can you explain why? (I'm considering writing tests for this.)

It makes sense to have multiple passes when you convert the string to HTML and some non-strict bold emphasis is left over in the end, but in this case it is probably redundant. I don't know for sure, though, until I tinkered with this some more.

@macteo
Copy link
Owner

macteo commented Aug 11, 2017

Unfortunately I cannot explain it: I've taken the regexes from Markingbird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants