From 684487984dc02757e1c31b79ecbe3d3f7935d15d Mon Sep 17 00:00:00 2001 From: Shawna Monero Date: Wed, 7 Aug 2024 21:33:21 -0700 Subject: [PATCH] does it still work? --- .../neptune/gateway/event/comment_handler_test.go | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/server/neptune/gateway/event/comment_handler_test.go b/server/neptune/gateway/event/comment_handler_test.go index a0d27b100..5c83873d8 100644 --- a/server/neptune/gateway/event/comment_handler_test.go +++ b/server/neptune/gateway/event/comment_handler_test.go @@ -220,7 +220,6 @@ func TestCommentEventWorkerProxy_HandleApplyComment_RequirementsFailed(t *testin expectedT: t, } - writer := &mockSnsWriter{} scheduler := &sync.SynchronousScheduler{Logger: logger} commentCreator := &mockCommentCreator{} statusUpdater := &mockStatusUpdater{} @@ -237,7 +236,6 @@ func TestCommentEventWorkerProxy_HandleApplyComment_RequirementsFailed(t *testin assert.False(t, statusUpdater.isCalled) assert.False(t, commentCreator.isCalled) assert.False(t, testSignaler.called) - assert.False(t, writer.isCalled) } func TestCommentEventWorkerProxy_HandleApplyComment(t *testing.T) { @@ -295,8 +293,6 @@ func TestCommentEventWorkerProxy_HandleApplyComment(t *testing.T) { }, }, } - - writer := &mockSnsWriter{} scheduler := &sync.SynchronousScheduler{Logger: logger} commentCreator := &mockCommentCreator{} statusUpdater := &mockStatusUpdater{} @@ -314,7 +310,6 @@ func TestCommentEventWorkerProxy_HandleApplyComment(t *testing.T) { assert.False(t, statusUpdater.isCalled) assert.False(t, commentCreator.isCalled) assert.True(t, testSignaler.called()) - assert.False(t, writer.isCalled) } func TestCommentEventWorkerProxy_HandlePlanComment_NoCmds(t *testing.T) { @@ -340,7 +335,6 @@ func TestCommentEventWorkerProxy_HandlePlanComment_NoCmds(t *testing.T) { }, InstallationToken: 123, } - writer := &mockSnsWriter{} scheduler := &sync.SynchronousScheduler{Logger: logger} commentCreator := &mockCommentCreator{} statusUpdater := &multiMockStatusUpdater{ @@ -385,7 +379,6 @@ func TestCommentEventWorkerProxy_HandlePlanComment_NoCmds(t *testing.T) { assert.False(t, statusUpdater.AllCalled()) assert.False(t, commentCreator.isCalled) assert.False(t, testSignaler.called) - assert.False(t, writer.isCalled) } func TestCommentEventWorkerProxy_HandleApplyComment_NoCmds(t *testing.T) { @@ -411,7 +404,6 @@ func TestCommentEventWorkerProxy_HandleApplyComment_NoCmds(t *testing.T) { }, InstallationToken: 123, } - writer := &mockSnsWriter{} scheduler := &sync.SynchronousScheduler{Logger: logger} commentCreator := &mockCommentCreator{} statusUpdater := &multiMockStatusUpdater{ @@ -440,7 +432,6 @@ func TestCommentEventWorkerProxy_HandleApplyComment_NoCmds(t *testing.T) { assert.False(t, statusUpdater.AllCalled()) assert.False(t, commentCreator.isCalled) assert.False(t, testSignaler.called) - assert.False(t, writer.isCalled) } func TestCommentEventWorkerProxy_HandlePlanComment(t *testing.T) { @@ -488,7 +479,6 @@ func TestCommentEventWorkerProxy_HandlePlanComment(t *testing.T) { }, InstallationToken: 123, } - writer := &mockSnsWriter{} scheduler := &sync.SynchronousScheduler{Logger: logger} commentCreator := &mockCommentCreator{} statusUpdater := &mockStatusUpdater{} @@ -509,7 +499,6 @@ func TestCommentEventWorkerProxy_HandlePlanComment(t *testing.T) { assert.False(t, commentCreator.isCalled) assert.False(t, deploySignaler.called) assert.True(t, prSignaler.called) - assert.True(t, writer.isCalled) } func TestCommentEventWorkerProxy_HandlePlanCommentAllocatorEnabled(t *testing.T) { @@ -557,7 +546,6 @@ func TestCommentEventWorkerProxy_HandlePlanCommentAllocatorEnabled(t *testing.T) }, InstallationToken: 123, } - writer := &mockSnsWriter{} scheduler := &sync.SynchronousScheduler{Logger: logger} commentCreator := &mockCommentCreator{} statusUpdater := &mockStatusUpdater{} @@ -577,7 +565,6 @@ func TestCommentEventWorkerProxy_HandlePlanCommentAllocatorEnabled(t *testing.T) assert.False(t, statusUpdater.isCalled) assert.False(t, commentCreator.isCalled) assert.False(t, testSignaler.called) - assert.True(t, writer.isCalled) assert.True(t, prSignaler.called) }