Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Input Min Length #74

Open
Jnb2387 opened this issue Jun 5, 2020 · 3 comments
Open

Search Input Min Length #74

Jnb2387 opened this issue Jun 5, 2020 · 3 comments

Comments

@Jnb2387
Copy link

Jnb2387 commented Jun 5, 2020

Super helpful project!
Would be great to see a minimum input length parameter before the search would get set to the database. I use this for addresses and for example when searching for 123 main st, I dont really want to be searching for 123 as I am tying so maybe setting the limit to 4 or 5 characters it would reduce the first lag I see on the results (even with a gin index).

@rugbygis
Copy link

I would counter this by adding that the conception of the plugin is to seach a single address string and pull out any data that meets part of the typed criteria. Limiting that would removed the intension of the plugin - what you need is a multi-column search facility and that isn't what this plugin is. I would strongly argue against this request.

@Jnb2387
Copy link
Author

Jnb2387 commented Jun 24, 2020

@rugbygis I am not sure I follow that logic. I do not need multicolumn search, our addresses work fine searching as is. I am just under the impression that adding a limit capability would just not kick off the search until a certain amount of characters is input. I would assume setting this to a default of 0 would not change your result from what they are currently.

@rugbygis
Copy link

Sorry. I thought you meant having the restriction as a default. You are absolutely right, having the ability to not search until a number of characters had been reached would be an advantage based on the data you were searching so I apologise for the post and didn't mean to diminish your suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants