Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUR-25] Try to remove uneeded pub modifiers through brute-force #1025

Closed
huitseeker opened this issue Jan 5, 2024 · 0 comments
Closed

[LUR-25] Try to remove uneeded pub modifiers through brute-force #1025

huitseeker opened this issue Jan 5, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@huitseeker
Copy link
Contributor

huitseeker commented Jan 5, 2024

In the course of making really sure the visibility modifiers in Arecibo were set as tightly as possible, I've written a small script to brute-force that:
https://gist.github.com/huitseeker/99ba921da591497de7879d1724e3e96b

See some selected results in lurk-lang/arecibo#239

It would be interesting to run this on the Lurk code base and see if there are pub annotations that do not need to be there.

Caution

We should try to avoid breaking public dependents needlessly. When in doubt, use the #[deprecated(since = "...")] attribute rather than remove blindly. Note this script will turn up false positives, a typical example being error types which need to be public to surface errors from your API.

Warning

rename 'gfind' to 'find' and 'gsed' to 'sed' in the script before using if you're on a Linux machine where gnu variants of these utilities are the default.

From SyncLinear.com | LUR-25

@huitseeker huitseeker added enhancement New feature or request help wanted Extra attention is needed labels Jan 5, 2024
@huitseeker huitseeker changed the title Try to remove uneeded pub modifiers through brute-force [LUR-25] Try to remove uneeded pub modifiers through brute-force Jan 5, 2024
@huitseeker huitseeker closed this as not planned Won't fix, can't repro, duplicate, stale Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant