From 5fa3f4b6a63072a00e4f1e8d47a9efa84d1f8989 Mon Sep 17 00:00:00 2001 From: Vince Loewe Date: Wed, 10 Jul 2024 00:44:26 +0100 Subject: [PATCH] improve --- packages/frontend/components/analytics/LineChart.tsx | 4 ++-- packages/frontend/pages/analytics.tsx | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/frontend/components/analytics/LineChart.tsx b/packages/frontend/components/analytics/LineChart.tsx index dfcac036..7cc8fa46 100644 --- a/packages/frontend/components/analytics/LineChart.tsx +++ b/packages/frontend/components/analytics/LineChart.tsx @@ -57,7 +57,7 @@ function prepareDataForRecharts( props.forEach((prop) => { if (splitBy) { uniqueSplitByValues.forEach((splitByValue) => { - dayData[`${splitByValue} ${prop}`] = findDataValue( + dayData[`${splitByValue || "(unknown)"} ${prop}`] = findDataValue( data, splitBy, splitByValue, @@ -147,7 +147,7 @@ const formatDate = (date, granularity) => { if (!date) return switch (granularity) { case "daily": - return format(parseISO(date), "MMM d") + return format(parseISO(date), "MMM do") case "hourly": return format(parseISO(date), "eee, HH'h'") case "weekly": diff --git a/packages/frontend/pages/analytics.tsx b/packages/frontend/pages/analytics.tsx index 9a509289..9403ee4a 100644 --- a/packages/frontend/pages/analytics.tsx +++ b/packages/frontend/pages/analytics.tsx @@ -25,7 +25,7 @@ import { } from "@mantine/core" import { DatePickerInput } from "@mantine/dates" import "@mantine/dates/styles.css" -import { useLocalStorage } from "@mantine/hooks" +import { useLocalStorage, useSessionStorage } from "@mantine/hooks" import { IconCalendar, IconChartAreaLine, @@ -322,7 +322,7 @@ function ChartTooltip({ label, payload }: ChartTooltipProps) { // TODO: refactor (put utils functions and components in other file) // TODO: typescript everywhere export default function Analytics() { - const [dateRange, setDateRange] = useLocalStorage({ + const [dateRange, setDateRange] = useSessionStorage({ key: "dateRange-analytics", getInitialValueInEffect: false, deserialize: deserializeDateRange,