Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel button on change password is no-op when fields empty #72

Open
jblachly opened this issue Dec 14, 2023 · 1 comment
Open

Cancel button on change password is no-op when fields empty #72

jblachly opened this issue Dec 14, 2023 · 1 comment

Comments

@jblachly
Copy link

The cancel button at the change password screen does nothing when fields are empty (not validating).

In Firefox, it appears to be a no-op. Safari shows "Fill out this field" hint when clicking cancel. Interestingly, passwords don't need to match in order to pass "validation" for purposes of cancelling.

Behavior is as expected in all browsers using default theme.

Keycloak version: 21.1.2
Keywind version: 6e5ef06

@jblachly
Copy link
Author

This is because keywind includes the required attribute on the password and password confirmation fields, in combination with the fact that the "cancel" button is a form submit button.

Note that the base theme does not include the required attributes: https://github.com/keycloak/keycloak/blob/main/themes/src/main/resources/theme/base/login/login-update-password.ftl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant