Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor game identifier, steam client and steam app data model #198

Closed
5 tasks done
lukatarman opened this issue Dec 5, 2023 · 0 comments
Closed
5 tasks done

Refactor game identifier, steam client and steam app data model #198

lukatarman opened this issue Dec 5, 2023 · 0 comments
Assignees
Labels
highest Priority of the feature refactoring Improving of code

Comments

@lukatarman
Copy link
Owner

lukatarman commented Dec 5, 2023

Description

  • Refactor the game identifier, the steam client and steam app data model. The files have a lot of repeating code that can be refactored and made much easier to read & understand.

Technical Design

  • in the steam app data mode, change the specific triedVia methods into one triedViaSource(source){} method
  • same with the new failedVia method
  • in the steam client, do similar with the html page request methods
  • rename tryViaSteamWeb, etc to checkIfGameViaSteamWeb, etc
  • in the game identifier refactor as you see fit. It will become clearer when everything else is refactored. TBD.

Only start this issue after #199 and #200 are finished

@lukatarman lukatarman added this to the Minimum Viable Product milestone Dec 5, 2023
@lukatarman lukatarman added the refactoring Improving of code label Dec 5, 2023
@lukatarman lukatarman changed the title Refactor triedVia properties to failedVia Refactor game identifier and steam client Dec 7, 2023
@lukatarman lukatarman changed the title Refactor game identifier and steam client Refactor game identifier, steam client and steam app data model Dec 7, 2023
@lukatarman lukatarman self-assigned this Dec 7, 2023
@lukatarman lukatarman added high Priority of the feature highest Priority of the feature and removed high Priority of the feature labels Dec 7, 2023
@lukatarman lukatarman linked a pull request Dec 18, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
highest Priority of the feature refactoring Improving of code
Projects
None yet
Development

No branches or pull requests

1 participant