Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer option to turn it on and off per assignment via a checkbox #1

Open
xow opened this issue Jul 25, 2017 · 1 comment
Open

Offer option to turn it on and off per assignment via a checkbox #1

xow opened this issue Jul 25, 2017 · 1 comment

Comments

@xow
Copy link

xow commented Jul 25, 2017

Right now it's automatically enabled for all assignments. That's fine because it won't display any of the structured feedback fields if they are empty. But the convention is to have a checkbox.

"Nice to have" rather than necessary

@tonyjbutler
Copy link
Member

Hi John. The plugin actually started out with the standard 'on/off switch' but it just seemed like an unnecessary extra box for the teacher to tick before they could start configuring the actual criteria. So I removed it and made the plugin enable/disable itself automatically based on whether or not any criteria have been defined.

When I get chance I'll add an admin config setting to make the enabling of the plugin a manual checkbox option. I guess there could be some value in being able to define a set of criteria and then temporarily disable the instance without losing the config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants